[rush-lib] ProjectChangeAnalyzer should analyze the scope of impact of pnpm-lock.yaml changes across all subspaces #5482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pm-lock.yaml changes
LPegasus
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
octogonz
reviewed
Dec 3, 2025
libraries/rush-lib/src/logic/test/ProjectChangeAnalyzer.test.ts
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Dec 3, 2025
libraries/rush-lib/src/logic/test/ProjectChangeAnalyzer.test.ts
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Dec 3, 2025
...ft/rush/fix-project-change-analyzer-nondefault-subspace-pnpmlock-check_2025-12-03-13-27.json
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Dec 3, 2025
Collaborator
|
I added some stylistic feedback but otherwise LGTM. Thanks for adding tests! 🏅 |
dmichon-msft
reviewed
Dec 3, 2025
libraries/rush-lib/src/logic/test/ProjectChangeAnalyzer.test.ts
Outdated
Show resolved
Hide resolved
...epoWithSubspaces/common/config/subspaces/project-change-analyzer-test-subspace/.pnpmfile.cjs
Outdated
Show resolved
Hide resolved
…default-subspace-pnpmlock-check_2025-12-03-13-27.json Co-authored-by: Pete Gonzalez <4673363+octogonz@users.noreply.github.com>
Co-authored-by: Pete Gonzalez <4673363+octogonz@users.noreply.github.com>
…for subspaces iteration
1. Fix `.pnpmfile.cjs` `readPackage` function is not defined. 2. Fix the comment of why 'e' is not in changedProjects.
dmichon-msft
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5480
Details
Q: How did you solve the problem?
A: Following the current logic of how to analyze default subspace
pnpm-lock.yamlchanges. Refactor the logic to run for all subspaces.Q: Mention any alternate approaches you considered.
A: I couldn't come up with a better alternative.
Q: Did you completely solve the problem, or are some cases not handled yet?
A: Yes. I think so.
Q: Does this change break backwards compatibility?
A: Yes.
Q: Could any aspects of your change impact performance?
A: For monorepo with many subspaces projects, it will take more time to check the pnpm-lock.yaml impact.
How it was tested
libraries/rush-lib/src/logic/test/repoWithSubspacesto test.rush list -t git:mainto check the listed projectsImpacted documentation
None